Add constructors and mutators useful downstream #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful when a user generates an llvm::Module that may have multiple entry points, as the Qwerty compiler/runtime does.
In my experience, it has been easier to treat XaccQuantum as a singleton to avoid issues with XACC initializing itself twice. It is probably cleaner to pass (accelerator, shots) via qiree::Executor, but this solves my immediate implementaiton problem in the Qwerty compiler/runtime.
ausbin
force-pushed
the
feature/constructors-mutators
branch
from
c50dfc4
to
67a1139
Compare
sethrj
requested changes
Jul 31, 2024
| @@ -45,6 +45,9 @@ class Module | |||
| // Construct from an externally created LLVM module | |||
| explicit Module(UPModule&& module); | |||
|
|
|||
| // Construct from an externally created LLVM module and an entry point | |||
| explicit Module(UPModule&& module, std::string const& entrypoint); | |||
There was a problem hiding this comment.
Since there's more than one argument we don't have to worry about implicit conversion:
Suggested change
| explicit Module(UPModule&& module, std::string const& entrypoint); | |
| Module(UPModule&& module, std::string const& entrypoint); |
| accelerator_ = xacc::getAccelerator(accel_name); | ||
| QIREE_VALIDATE(accelerator_, << "failed to create accelerator"); | ||
| accelerator_->updateConfiguration({{"shots", static_cast<int>(shots)}}); | ||
| set_accelerator_and_shots(accel_name, shots); |
There was a problem hiding this comment.
Is there a reason to "create and then initialize" the class like this? Best practices say initialization should take place at construction. It improves performance sometimes, but more importantly it helps "reasoning" about the state of the code because you don't have to worry about some other part of the code changing the state of an object that you got.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are useful for me downstream in the Qwerty compiler/runtime.
It would be nicer to pass the accelerator and shots as arguments to
qiree::Executorsomehow, but this solves my immediate engineering problem.Testing
Once rebased against #4, this builds and passes
ctest. I previously tested this code end-to-end in the Qwerty runtime but the code is in a state where it will be tough to do that again.